Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files

com/ivata/mask/web/format/CaseFormat.java

Error		Line
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	53
	Parameter textParam should be final.	66
	Parameter lowerParam should be final.	86

com/ivata/mask/web/format/DateFormatter.java

Error		Line
	File does not end with a newline.	0

com/ivata/mask/web/struts/DialogForm.java

Error		Line
	Unused import - javax.servlet.ServletException.	93
	Unused @throws tag for 'OperationNotSupported'.	205
	Expected @throws tag for 'OperationNotSupportedException'.	209
	Parameter defaultForwardApplyParam should be final.	397
	Line is longer than 80 characters.	407
	Parameter defaultForwardDeleteParam should be final.	409
	Parameter defaultForwardOkParam should be final.	422
	Expected @param tag for 'request'.	543
	Expected @param tag for 'session'.	544

com/ivata/mask/web/struts/FindAction.java

Error		Line
	'catch' is not followed by whitespace.	247
	Parameter baseClassNameParam should be final.	313
	Parameter displayOnlyParam should be final.	327
	Parameter idStringParam should be final.	340

com/ivata/mask/web/struts/InputMaskAction.java

Error		Line
	Parameter mappingParam should be final.	171
	Parameter errorsParam should be final.	171
	Parameter formParam should be final.	172
	Parameter requestParam should be final.	172
	Parameter responseParam should be final.	173
	Parameter sessionParam should be final.	173
	Expected @param tag for 'defaultForward'.	284

com/ivata/mask/web/struts/InputMaskForm.java

Error		Line
	Unused @throws tag for 'OperationNotSupported'.	174
	Expected @throws tag for 'OperationNotSupportedException'.	178
	Line is longer than 80 characters.	305
	Parameter applyButtonHiddenParam should be final.	335
	Parameter clearButtonHiddenParam should be final.	347
	Parameter deleteButtonHiddenParam should be final.	359
	Parameter deleteWithoutWarnParam should be final.	371
	Parameter refreshOpenerParam should be final.	392
	Parameter resourceFieldPathParam should be final.	404
	Line is longer than 80 characters.	416

com/ivata/mask/web/struts/MaskAction.java

Error		Line
	Line is longer than 80 characters.	416
	Line is longer than 80 characters.	418
	Line is longer than 80 characters.	420
	Line has trailing spaces.	432
	Line is longer than 80 characters.	432
	Parameter defaultValue should be final.	510
	Expected @param tag for 'defaultValue'.	510
	Line is longer than 80 characters.	614

com/ivata/mask/web/struts/MaskRequestProcessor.java

Error		Line
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	116
	Line is longer than 80 characters.	182
	Javadoc has empty description section.	231
	Parameter servletParam should be final.	248
	Parameter moduleConfigParam should be final.	248
	Parameter implementationParam should be final.	381

com/ivata/mask/web/struts/MaskRequestProcessorImplementation.java

Error		Line
	Line is longer than 80 characters.	140
	Line is longer than 80 characters.	164
	Expected @param tag for 'fieldValueConvertorFactoryParam'.	166
	Expected @param tag for 'actions'.	203
	Expected @param tag for 'servlet'.	204
	Expected @throws tag for 'SystemException'.	205
	Line is longer than 80 characters.	351
	Parameter servletParam should be final.	353
	Parameter moduleConfigParam should be final.	353
	Line is longer than 80 characters.	381
	Line is longer than 80 characters.	489
	Parameter form should be final.	510
	Parameter parameterName should be final.	510
	Parameter request should be final.	511
	Parameter allErrors should be final.	511
	Parameter form should be final.	593
	Parameter parameterName should be final.	593
	Parameter request should be final.	594
	Line has trailing spaces.	611

com/ivata/mask/web/struts/MaskTilesRequestProcessor.java

Error		Line
	Unused import - org.apache.struts.action.RequestProcessor.	90
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	113
	'assert' is not followed by whitespace.	170
	Line is longer than 80 characters.	180
	'assert' is not followed by whitespace.	214
	Javadoc has empty description section.	226
	Parameter servletParam should be final.	242
	Parameter moduleConfigParam should be final.	242
	'assert' is not followed by whitespace.	367
	Parameter implementationParam should be final.	378

com/ivata/mask/web/struts/ValidationErrorsConvertor.java

Error		Line
	Parameter locale should be final.	136
	Parameter bundle should be final.	136
	Parameter resourceFieldPath should be final.	137
	Parameter field should be final.	137
	Unused @param tag for 'messages'.	173
	Expected @param tag for 'locale'.	184
	'=' is not preceded with whitespace.	200
	'{' is not preceded with whitespace.	247

com/ivata/mask/web/struts/util/MessageResourcesHandling.java

Error		Line
	Unused import - org.apache.struts.taglib.TagUtils.	52
	Name 'FIELD_PREFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'.	71
	Variable 'FIELD_PREFIX' must be private and have accessor methods.	71
	Name 'SUBMIT_PREFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'.	95
	Variable 'SUBMIT_PREFIX' must be private and have accessor methods.	95
	Name 'TITLE_SUFFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'.	100
	Variable 'TITLE_SUFFIX' must be private and have accessor methods.	100
	Name 'VALUE_SUFFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'.	105
	Variable 'VALUE_SUFFIX' must be private and have accessor methods.	105
	More than 7 parameters.	147
	Parameter mandatory should be final.	156
	More than 7 parameters.	262
	Parameter mandatory should be final.	271
	First sentence should end with a period.	348
	More than 7 parameters.	393
	Parameter mandatory should be final.	401
	More than 7 parameters.	430
	Parameter mandatory should be final.	438
	Parameter bundle should be final.	544
	Javadoc has empty description section.	558
	Parameter bundle should be final.	571
	Parameter fullPath should be final.	572
	Parameter guessLabelParam should be final.	587

com/ivata/mask/web/tag/html/BaseTag.java

Error		Line
	Unclosed HTML tag found: <colin.macleod@ivata.com>	59
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	67
	Unclosed HTML tag found: <code>	81
	Parameter scheme should be final.	83
	Parameter serverName should be final.	84
	Parameter port should be final.	85
	Parameter uri should be final.	86
	',' is not followed by whitespace.	92
	',' is not followed by whitespace.	92

com/ivata/mask/web/tag/html/ButtonTag.java

Error		Line
	Missing a Javadoc comment.	225
	Missing a Javadoc comment.	228

com/ivata/mask/web/tag/html/CancelTag.java

Error		Line
	Missing a Javadoc comment.	227
	Missing a Javadoc comment.	240

com/ivata/mask/web/tag/html/CheckboxTag.java

Error		Line
	Missing a Javadoc comment.	220
	Missing a Javadoc comment.	233

com/ivata/mask/web/tag/html/FormTag.java

Error		Line
	Parameter buffer should be final.	678
	Line has trailing spaces.	688

com/ivata/mask/web/tag/html/HTMLTag.java

Error		Line
	Line is longer than 80 characters.	88

com/ivata/mask/web/tag/html/HiddenTag.java

Error		Line
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	76
	Line is longer than 80 characters.	118

com/ivata/mask/web/tag/html/LabelTag.java

Error		Line
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	115
	Missing a Javadoc comment.	239
	Missing a Javadoc comment.	328
	Parameter afterTextParam should be final.	335
	Parameter classNameParam should be final.	362

com/ivata/mask/web/tag/html/LinkTag.java

Error		Line
	Unclosed HTML tag found: <colin.macleod@ivata.com>	61

com/ivata/mask/web/tag/html/MaskProperties.java

Error		Line
	Variable 'propertiesToReset' must be private and have accessor methods.	351
	Method length is 202 lines (max allowed is 150).	361
	'-=' is not followed by whitespace.	437
	Parameter classNameParam should be final.	939

com/ivata/mask/web/tag/html/MultiboxTag.java

Error		Line
	Missing a Javadoc comment.	196
	Missing a Javadoc comment.	209

com/ivata/mask/web/tag/html/ResetTag.java

Error		Line
	Missing a Javadoc comment.	202
	Missing a Javadoc comment.	215

com/ivata/mask/web/tag/html/RewriteTag.java

Error		Line
	Unclosed HTML tag found: <colin.macleod@ivata.com>	64
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	72

com/ivata/mask/web/tag/html/SubmitTag.java

Error		Line
	Missing a Javadoc comment.	234
	Missing a Javadoc comment.	237

com/ivata/mask/web/tag/html/TextTag.java

Error		Line
	Line is longer than 80 characters.	160

com/ivata/mask/web/tag/util/BufferAppendTag.java

Error		Line
	Unused import - javax.servlet.jsp.JspWriter.	39
	Unused import - javax.servlet.jsp.tagext.BodyContent.	40
	Name 'logger' must match pattern '^[A-Z](_?[A-Z0-9]+)*$'.	58
	Parameter bufferNameParam should be final.	129

com/ivata/mask/web/tag/util/MapEntryTag.java

Error		Line
	Unused import - javax.servlet.jsp.JspWriter.	79
	Unused import - javax.servlet.jsp.tagext.BodyContent.	80